Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Linebender lint set. #20

Merged
merged 2 commits into from
Dec 6, 2024
Merged

Add Linebender lint set. #20

merged 2 commits into from
Dec 6, 2024

Conversation

xStrom
Copy link
Member

@xStrom xStrom commented Dec 6, 2024

Actually satisfying a good chunk of these lints is deferred and they are in an allow block.

Still, I did satisfy some of the lints.

Copy link
Member

@DJMcNab DJMcNab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd probably title this PR "Add Linebender Lint set", because there is no pre-existing Linebender lints in this repo, but the title suggests that there is

src/lib.rs Outdated
#![cfg_attr(all(not(feature = "std"), not(test)), no_std)]
#![forbid(unsafe_code)]
#![warn(missing_docs)]
#![doc(html_root_url = "https://docs.rs/simplecss/0.2.1")]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm fairly sure that this is unnecessary, but maybe it does something important?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe helps with linking types? We haven't needed it in any of our projects ever, so I tend to agree that it isn't needed. I'll remove it.

@xStrom xStrom changed the title Update to Linebender lint set v3. Add Linebender lint set. Dec 6, 2024
@xStrom xStrom added this pull request to the merge queue Dec 6, 2024
Merged via the queue into linebender:main with commit 6dd11ff Dec 6, 2024
15 checks passed
@xStrom xStrom deleted the lintv2 branch December 6, 2024 12:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants